From b5a9a1925af5f2ef1e161c4f718f9435684fd161 Mon Sep 17 00:00:00 2001 From: Roger Dingledine Date: Fri, 12 Sep 2003 06:18:38 +0000 Subject: [PATCH] serious bug in cpuworker. need to think about redesign or how to handle it. svn:r448 --- trunk/src/or/cpuworker.c | 1 + 1 file changed, 1 insertion(+) diff --git a/trunk/src/or/cpuworker.c b/trunk/src/or/cpuworker.c index 0b92733f2b..9d88afab6e 100644 --- a/trunk/src/or/cpuworker.c +++ b/trunk/src/or/cpuworker.c @@ -55,6 +55,7 @@ int connection_cpu_process_inbuf(connection_t *conn) { connection_fetch_from_buf(buf,LEN_ONION_RESPONSE,conn); + /* XXX conn->circ might already have been closed. Serious bug. Suck. */ if(*buf == 0 || conn->circ->p_conn == NULL || onionskin_process(conn->circ, buf+1, buf+1+DH_KEY_LEN) < 0) { log_fn(LOG_DEBUG,"decoding onion, onionskin_process, or p_conn failed. Closing.");