From 896ab165d96ba4fb9806cea09f4f7d7be6a26830 Mon Sep 17 00:00:00 2001 From: Roger Dingledine Date: Thu, 27 May 2021 14:22:22 -0400 Subject: [PATCH] clarify three comments based on code-spelunking with nickm --- src/core/or/circuitbuild.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/core/or/circuitbuild.c b/src/core/or/circuitbuild.c index 2bcc642a97..f2f3bb5b34 100644 --- a/src/core/or/circuitbuild.c +++ b/src/core/or/circuitbuild.c @@ -2019,7 +2019,7 @@ cpath_build_state_to_crn_ipv6_extend_flag(const cpath_build_state_t *state, } /** Decide a suitable length for circ's cpath, and pick an exit - * router (or use exit if provided). Store these in the + * router (or use exit_ei if provided). Store these in the * cpath. * * If is_hs_v3_rp_circuit is set, then this exit should be suitable to @@ -2072,7 +2072,7 @@ onion_pick_cpath_exit(origin_circuit_t *circ, extend_info_t *exit_ei, return 0; } -/** Give circ a new exit destination to exit, and add a +/** Give circ a new exit destination to exit_ei, and add a * hop to the cpath reflecting this. Don't send the next extend cell -- * the caller will do this if it wants to. */ @@ -2114,8 +2114,6 @@ circuit_extend_to_new_exit(origin_circuit_t *circ, extend_info_t *exit_ei) return -1; } - // XXX: Should cannibalized circuits be dirty or not? Not easy to say.. - return 0; }