From 705c1c28c710b70406712027833ab739729ee583 Mon Sep 17 00:00:00 2001 From: rl1987 Date: Fri, 5 Apr 2019 18:51:24 +0300 Subject: [PATCH 1/2] Call pre-commit hook from pre-push script --- scripts/git/pre-push.git-hook | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/scripts/git/pre-push.git-hook b/scripts/git/pre-push.git-hook index e7a72efa08..f329829346 100755 --- a/scripts/git/pre-push.git-hook +++ b/scripts/git/pre-push.git-hook @@ -27,6 +27,13 @@ ref_is_upstream_branch() { fi } +workdir=$(git rev-parse --show-toplevel) +if [ -x "$workdir/.git/hooks/pre-commit" ]; then + if ! "$workdir"/.git/hooks/pre-commit; then + exit 1 + fi +fi + # shellcheck disable=SC2034 while read -r local_ref local_sha remote_ref remote_sha do From e8e6931638a14a2c996e55d7c8342654fb546b34 Mon Sep 17 00:00:00 2001 From: rl1987 Date: Fri, 5 Apr 2019 19:03:41 +0300 Subject: [PATCH 2/2] Add changes file --- changes/ticket30033 | 4 ++++ 1 file changed, 4 insertions(+) create mode 100644 changes/ticket30033 diff --git a/changes/ticket30033 b/changes/ticket30033 new file mode 100644 index 0000000000..3f66d049c8 --- /dev/null +++ b/changes/ticket30033 @@ -0,0 +1,4 @@ + o Minor features (developer tooling): + - Call pre-commit git hook from pre-push hook to make sure we're + running documentation and code style checks before pushing to remote + git repository. Implements feature 30033.