torproject/tor
1
0
Fork 0
mirror of https://gitlab.torproject.org/tpo/core/tor.git synced 2024-12-06 19:41:15 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity

hs-v3: Return descriptor decoding status when storing as client

Browse Source 
This will allow us to callback into the HS subsytem depending on the decoding
status and return an extended SOCKS5 error code depending on the decoding
issue.

This is how we'll be able to tell the SocksPort connection if we are missing
or have bad client authorization for a service.

Part of #30382

Signed-off-by: David Goulet <dgoulet@torproject.org>
This commit is contained in:
David Goulet
2019-05-28 13:32:15 -04:00
committed by George Kadianakis
parent 96a53221b0
commit 7bba8bf72f
4 changed files with 39 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/feature/dirclient/dirclient.c
+4 -1
View File
@@ -2722,6 +2722,7 @@ handle_response_fetch_hsdesc_v3(dir_connection_t *conn,
const char *reason = args->reason;
const char *body = args->body;
const size_t body_len = args->body_len;
hs_desc_decode_status_t decode_status;
tor_assert(conn->hs_ident);
@@ -2731,7 +2732,9 @@ handle_response_fetch_hsdesc_v3(dir_connection_t *conn,
switch (status_code) {
case 200:
/* We got something: Try storing it in the cache. */
if (hs_cache_store_as_client(body, &conn->hs_ident->identity_pk) < 0) {
decode_status = hs_cache_store_as_client(body,
&conn->hs_ident->identity_pk);
if (decode_status != HS_DESC_DECODE_OK) {
log_info(LD_REND, "Failed to store hidden service descriptor");
/* Fire control port FAILED event. */
hs_control_desc_event_failed(conn->hs_ident, conn->identity_digest,