torproject/tor
1
0
Fork 0
mirror of https://gitlab.torproject.org/tpo/core/tor.git synced 2024-12-06 19:41:15 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity

Merge remote-tracking branch 'public/bug6538'

Browse Source 
Conflicts:
	configure.ac
This commit is contained in:
Nick Mathewson
2012-09-11 17:51:36 -04:00
parent b8f93c5dd7 9982122f34
commit 75c9ccd4f8
8 changed files with 330 additions and 156 deletions
Download Patch File Download Diff File Expand all files Collapse all files
changes/bug6538
+16
View File
@@ -0,0 +1,16 @@
o Minor bugfixes:
- Switch weighted node selection rule from using a list of doubles
to using a list of int64_t. This should make the process slightly
easier to debug and maintain. Needed for fix for bug 6538.
o Security features:
- Switch to a completely time-invariant approach for picking nodes
weighted by bandwidth. Our old approach would run through the
part of the loop after it had made its choice slightly slower
than it ran through the part of the loop before it had made its
choice. Fix for bug 6538.
o Code simplifications and refactoring:
- Move the core of our "choose a weighted element at random" logic
into its own function, and give it unit tests. Now the logic is
testable, and a little less fragile too.