From 54c9c8b04f6055dc4101b6a36cfb587af78dc9b4 Mon Sep 17 00:00:00 2001 From: Nick Mathewson Date: Wed, 23 Jan 2019 12:04:57 -0500 Subject: [PATCH] If address/get_if_addrs6 can't findipv6, log WARN, not ERR Fixes 29160, and allows 28668 (treating ERR logs as test failures) to procede. --- changes/ticket29160 | 4 ++++ src/test/test_address.c | 3 +-- 2 files changed, 5 insertions(+), 2 deletions(-) create mode 100644 changes/ticket29160 diff --git a/changes/ticket29160 b/changes/ticket29160 new file mode 100644 index 0000000000..8e11183064 --- /dev/null +++ b/changes/ticket29160 @@ -0,0 +1,4 @@ + o Minor bugfixes (tests): + - Do not log an error-level message if we fail to find an IPv6 + network interface from the unit tests. Fixes bug 29160; bugfix on + 0.2.7.3-rc. diff --git a/src/test/test_address.c b/src/test/test_address.c index 43467aca13..cfb32b855f 100644 --- a/src/test/test_address.c +++ b/src/test/test_address.c @@ -1013,7 +1013,7 @@ test_address_get_if_addrs6(void *arg) (void)arg; - rv = get_interface_address6(LOG_ERR, AF_INET6, &tor_addr); + rv = get_interface_address6(LOG_WARN, AF_INET6, &tor_addr); /* Work even on systems without IPv6 interfaces */ if (rv == 0) { @@ -1204,4 +1204,3 @@ struct testcase_t address_tests[] = { ADDRESS_TEST(tor_addr_in_same_network_family, 0), END_OF_TESTCASES }; -