From 4457c181f50b5bc3bb57f2d9ba73492e5b9eaa3f Mon Sep 17 00:00:00 2001 From: Roger Dingledine Date: Tue, 12 Jul 2005 23:21:15 +0000 Subject: [PATCH] note a worrying double-free possibility in torgzip. nick? svn:r4537 --- src/common/torgzip.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/common/torgzip.c b/src/common/torgzip.c index 8d4438907d..453ce6d8f3 100644 --- a/src/common/torgzip.c +++ b/src/common/torgzip.c @@ -208,7 +208,7 @@ tor_gzip_uncompress(char **out, size_t *out_len, *out_len = stream->total_out; if (inflateEnd(stream)!=Z_OK) { log_fn(LOG_WARN, "Error freeing gzip structures"); - goto err; + goto err; /* XXX this will try to inflateEnd again, right? is that bad? */ } tor_free(stream);