From 276f95182c864a4cb9457bf56d842ef297e2cd2b Mon Sep 17 00:00:00 2001 From: Andrea Shepard Date: Fri, 15 Jun 2012 20:54:45 -0700 Subject: [PATCH] Clean keys on stack in rend_service_rendezvous_has_opened() --- src/or/rendservice.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/src/or/rendservice.c b/src/or/rendservice.c index 50950d1ac2..acc3cea223 100644 --- a/src/or/rendservice.c +++ b/src/or/rendservice.c @@ -1847,9 +1847,16 @@ rend_service_rendezvous_has_opened(origin_circuit_t *circuit) /* Change the circuit purpose. */ circuit_change_purpose(TO_CIRCUIT(circuit), CIRCUIT_PURPOSE_S_REND_JOINED); - return; + goto done; + err: circuit_mark_for_close(TO_CIRCUIT(circuit), reason); + done: + memset(buf, 0, sizeof(buf)); + memset(serviceid, 0, sizeof(serviceid)); + memset(hexcookie, 0, sizeof(hexcookie)); + + return; } /*