torproject/tor
1
0
Fork 0
mirror of https://gitlab.torproject.org/tpo/core/tor.git synced 2024-12-06 19:41:15 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity

mainloop: Reactivate the linked connection event with a non empty list

Browse Source 
Linked connections aren't woken up by libevent due to I/O but rather
artificially so we can, by chunks, empty the spooled object(s).

Commit 5719dfb48f (in 0.3.4.1-alpha) made it
that the schedule_active_linked_connections_event would be only called once at
startup but this is wrong because then we would never go through again the
active linked connections.

Fortunately, everytime a new linked connection is created, the event is
activated and thus we would go through the active list again. On a busy relay,
this issue is mitigated by that but on a slower relays or bridge, a connection
could get stuck for a while until a new directory information request would
show up.

Fixes #28717, #28912
This commit is contained in:
David Goulet
2018-12-21 11:17:45 -05:00
parent 633813e313
commit 2420e84ba4
2 changed files with 20 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
changes/ticket28912
+6
View File
@@ -0,0 +1,6 @@
o Major bugfixes (relay, directory):
- A connection serving directory information wouldn't get reactivated after
the first chunk of data was sent (usually 32KB). Tor now always activate
the main loop event that goes through these connections as long as at
least one connection is still active. Fixes bug 28912; bugfix on
0.3.4.1-alpha. Patch by "cypherpunks3".