torproject/tor
1
0
Fork 0
mirror of https://gitlab.torproject.org/tpo/core/tor.git synced 2024-12-06 19:41:15 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity

Prevention: never die from extend_info_from_node() failure.

Browse Source 
Bug 21242 occurred because we asserted that extend_info_from_node()
had succeeded...even though we already had the code to handle such a
failure.  We fixed that in 93b39c5162.

But there were four other cases in our code where we called
extend_info_from_node() and either tor_assert()ed that it returned
non-NULL, or [in one case] silently assumed that it returned
non-NULL. That's not such a great idea.  This patch makes those
cases check for a bug of this kind instead.

Fixes bug 21372; bugfix on 0.2.3.1-alpha when
extend_info_from_node() was introduced.
This commit is contained in:
Nick Mathewson
2017-02-03 10:14:25 -05:00
parent 9d5a9feb40
commit 19e25d5cab
4 changed files with 12 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
changes/bug21372
+4
View File
@@ -0,0 +1,4 @@
o Minor bugfixes (client):
- Always recover from failures in extend_info_from_node(),
in an attempt to prevent any recurrence of bug 21242.
Fixes bug 21372; bugfix on 0.2.3.1-alpha.