torproject/tor
1
0
Fork 0
mirror of https://gitlab.torproject.org/tpo/core/tor.git synced 2024-12-06 19:41:15 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity

Remove abort handler from the backtrace generator

Browse Source 
The abort handler masks the exit status of the backtrace generator by
capturing the abort signal from the backtrace handler and exiting with
zero. Because the output of the backtrace generator is meant to be piped
to `bt_test.py`, its exit status is unimportant and is currently
ignored.

The abort handler calls `exit(3)` which is not asynchronous-signal-safe
and calling it in this context is undefined behavior [0].

Closes ticket 21026.

[0] https://www.securecoding.cert.org/confluence/x/34At
This commit is contained in:
cypherpunks
2016-12-18 15:55:37 +00:00
committed by Nick Mathewson
parent d3c0b137af
commit 04f21f0322
2 changed files with 3 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files
changes/ticket21026
+3
View File
@@ -0,0 +1,3 @@
o Minor bugfixes (testing):
- Remove undefined behavior from the backtrace generator by removing
its signal handler. Fixes bug 21026; bugfix on 0.2.5.2-alpha.