Remove fgets() compatbility function and related tests.

This patch removes the `tor_fgets()` wrapper around `fgets(3)` since it
is no longer needed. The function was created due to inconsistency
between the returned values of `fgets(3)` on different versions of Unix
when using `fgets(3)` on non-blocking file descriptors, but with the
recent changes in bug #21654 we switch from unbuffered to direct I/O on
non-blocking file descriptors in our utility module.

We continue to use `fgets(3)` directly in the geoip and dirserv module
since this usage is considered safe.

This patch also removes the test-case that was created to detect
differences in the implementation of `fgets(3)` as well as the changes
file since these changes was not included in any releases yet.

See: https://bugs.torproject.org/21654
This commit is contained in:
Alexander Færøy
2017-03-08 23:11:42 +01:00
parent 02ef06516e
commit 02fc0a5ecf
6 changed files with 3 additions and 159 deletions
-4
View File
@@ -1,4 +0,0 @@
o Minor bugfixes (portability):
- Add Tor compatibility function for fgets(3) due to inconsistency of
returned values in different supported C libraries. This fixes unit test
failures reported on FreeBSD. Fixes bug 20988.