From 00c2ba4841ddeaca80d48eed4f16d2b8f006187d Mon Sep 17 00:00:00 2001
From: Roger Dingledine <arma@torproject.org>
Date: Mon, 15 Aug 2005 09:19:55 +0000
Subject: [PATCH] resolve a XXX

svn:r4783
---
 src/or/config.c | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/or/config.c b/src/or/config.c
index 61883b11a9..70472f3cc4 100644
--- a/src/or/config.c
+++ b/src/or/config.c
@@ -1515,11 +1515,18 @@ options_validate(or_options_t *options)
     result = -1;
   }
 
-  /* XXX might similarly want to check the other *BindAddress options */
   if (options->ORPort == 0 && options->ORBindAddress != NULL) {
     log(LOG_WARN, "ORPort must be defined if ORBindAddress is defined.");
     result = -1;
   }
+  if (options->DirPort == 0 && options->DirBindAddress != NULL) {
+    log(LOG_WARN, "DirPort must be defined if DirBindAddress is defined.");
+    result = -1;
+  }
+  if (options->SocksPort == 0 && options->SocksBindAddress != NULL) {
+    log(LOG_WARN, "SocksPort must be defined if SocksBindAddress is defined.");
+    result = -1;
+  }
 
   if (validate_data_directory(options)<0) {
     log(LOG_WARN, "Invalid DataDirectory");