From 5ff99901d29fe0645edf5f5cfc1d15e2ca6f4686 Mon Sep 17 00:00:00 2001 From: teor Date: Thu, 17 Oct 2019 15:32:21 +1000 Subject: [PATCH 1/5] configure: Clarify the description of --disable-module-dirauth Part of 32123. --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index f610fb0a07..0540ffb40c 100644 --- a/configure.ac +++ b/configure.ac @@ -258,7 +258,7 @@ m4_define(MODULES, dirauth) dnl Directory Authority module. AC_ARG_ENABLE([module-dirauth], AS_HELP_STRING([--disable-module-dirauth], - [Build tor without the Directory Authority module: tor can not run as an authority]), + [Build tor without the Directory Authority module: tor can not run as a directory authority or bridge authority]), [], dnl Action if-given AC_DEFINE([HAVE_MODULE_DIRAUTH], [1], [Compile with Directory Authority feature support])) From f59c4a094090e0c5cfe4c5a7aa3ffdc357fc95f0 Mon Sep 17 00:00:00 2001 From: teor Date: Thu, 17 Oct 2019 16:04:39 +1000 Subject: [PATCH 2/5] configure: Interpret --disable-module-dirauth=no correctly Fixes bug 32134; bugfix on 0.3.4.1-alpha. --- configure.ac | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/configure.ac b/configure.ac index 0540ffb40c..11d49df458 100644 --- a/configure.ac +++ b/configure.ac @@ -258,11 +258,11 @@ m4_define(MODULES, dirauth) dnl Directory Authority module. AC_ARG_ENABLE([module-dirauth], AS_HELP_STRING([--disable-module-dirauth], - [Build tor without the Directory Authority module: tor can not run as a directory authority or bridge authority]), - [], dnl Action if-given - AC_DEFINE([HAVE_MODULE_DIRAUTH], [1], - [Compile with Directory Authority feature support])) -AM_CONDITIONAL(BUILD_MODULE_DIRAUTH, [test "x$enable_module_dirauth" != "xno"]) + [Build tor without the Directory Authority module: tor can not run as a directory authority or bridge authority])) +AM_CONDITIONAL(BUILD_MODULE_DIRAUTH,[test "x$enable_module_dirauth" != "xno"]) +AM_COND_IF(BUILD_MODULE_DIRAUTH, + AC_DEFINE([HAVE_MODULE_DIRAUTH], [1], + [Compile with Directory Authority feature support])) dnl Helper variables. TOR_MODULES_ALL_ENABLED= From 4442eef0b3d308008992ae71fcd78ba52f305cd7 Mon Sep 17 00:00:00 2001 From: teor Date: Fri, 18 Oct 2019 17:16:32 +1000 Subject: [PATCH 3/5] configure: Interpret --with-tcmalloc=no correctly Fixes bug 32124; bugfix on 0.2.0.20-rc. --- configure.ac | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/configure.ac b/configure.ac index 11d49df458..da74042dc8 100644 --- a/configure.ac +++ b/configure.ac @@ -1894,8 +1894,7 @@ if test "$tor_cv_uint8_uchar" = "no"; then fi AC_ARG_WITH(tcmalloc, -AS_HELP_STRING(--with-tcmalloc, [use tcmalloc memory allocation library. Deprecated; see --with-malloc]), -[ tcmalloc=yes ], [ tcmalloc=no ]) +AS_HELP_STRING(--with-tcmalloc, [use tcmalloc memory allocation library. Deprecated; see --with-malloc])) default_malloc=system @@ -1904,7 +1903,7 @@ if test "x$enable_openbsd_malloc" = "xyes" ; then default_malloc=openbsd fi -if test "x$tcmalloc" = "xyes"; then +if test "x$with_tcmalloc" = "xyes"; then AC_MSG_NOTICE([The --with-tcmalloc argument is deprecated; use --with-malloc=tcmalloc instead.]) default_malloc=tcmalloc fi From ac71ad662c80c034517dc882703f735df0648e21 Mon Sep 17 00:00:00 2001 From: teor Date: Fri, 18 Oct 2019 17:18:52 +1000 Subject: [PATCH 4/5] configure: Stop failing when jemalloc is requested, but tcmalloc is not found Fixes bug 32124; bugfix on 0.3.5.1-alpha. --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index da74042dc8..b8b745e980 100644 --- a/configure.ac +++ b/configure.ac @@ -1934,7 +1934,7 @@ AS_CASE([$malloc], have_jemalloc=yes, have_jemalloc=no) - if test "x$have_tcmalloc" = "xno" ; then + if test "x$have_jemalloc" = "xno" ; then AC_MSG_ERROR([Unable to find jemalloc requested by --with-malloc, $pkg_config_user_action, or set JEMALLOC_CFLAGS and JEMALLOC_LIBS.]) fi From b3fc3b609bb222ecbd1dd8a28993f3b19dc8bfd4 Mon Sep 17 00:00:00 2001 From: teor Date: Fri, 18 Oct 2019 17:26:09 +1000 Subject: [PATCH 5/5] changes: file for 32124. --- changes/bug32124 | 7 +++++++ 1 file changed, 7 insertions(+) create mode 100644 changes/bug32124 diff --git a/changes/bug32124 b/changes/bug32124 new file mode 100644 index 0000000000..164b33c7e3 --- /dev/null +++ b/changes/bug32124 @@ -0,0 +1,7 @@ + o Minor bugfixes (build system): + - Stop failing when jemalloc is requested, but tcmalloc is not found. + Fixes bug 32124; bugfix on 0.3.5.1-alpha. + - Interpret --disable-module-dirauth=no correctly. + Fixes bug 32124; bugfix on 0.3.4.1-alpha. + - Interpret --with-tcmalloc=no correctly. + Fixes bug 32124; bugfix on 0.2.0.20-rc.