Commit Graph

1166 Commits

Author SHA1 Message Date
Adam Warner 6e5bbfb68a Check IP addresses read in from dns-server.conf are valid before adding them to the array.
Fix for CVE-2020-12620

Signed-off-by: Adam Warner <me@adamwarner.co.uk>
2020-05-03 22:47:33 +01:00
DL6ER 81a2932f6a Merge branch 'release/v5.0' into tweak/trim_domains_input
Signed-off-by: DL6ER <dl6er@dl6er.de>
2020-04-28 21:12:45 +02:00
Dan Schaper eaf2d7ed62 Merge pull request #1226 from pi-hole/tweak/allow_()_in_urls
Allow ( and ) in adlist URLs.
2020-04-28 11:46:32 -07:00
DL6ER 527c2f114b Merge pull request #1229 from pi-hole/tweak/custom_dns
Custom DNS page -> Local DNS Records
2020-04-28 20:30:23 +02:00
DL6ER 9cf73959fd Rename Custom DNS page.
Signed-off-by: DL6ER <dl6er@dl6er.de>
2020-04-28 18:23:13 +00:00
DL6ER abf6e9f7a2 Merge pull request #1210 from pi-hole/fix/regex_link_multiple_tabs
Prevent multiple tabs from being opened when clicking on a regex link on the Query Log page
2020-04-28 20:06:03 +02:00
DL6ER 4889350038 Merge branch 'release/v5.0' into tweak/trim_domains_input
Signed-off-by: DL6ER <dl6er@dl6er.de>
2020-04-28 17:30:13 +00:00
DL6ER 79539bdd6c Merge pull request #1121 from pi-hole/fix/queries_over_time
Fix tooltip percentage computation and more...
2020-04-28 04:36:02 +02:00
DL6ER 84046528bf Allow ( and ) in adlist URLs.
Signed-off-by: DL6ER <dl6er@dl6er.de>
2020-04-26 09:31:45 +02:00
DL6ER f17b216b6b As of ICU 55.1 (released 2015-04-01) the IDNA2003 APIs are deprecated, because UTS #46 should be preferred over the obsolete IDNA 2003 variant. Implement this change. Fixes #1223
Signed-off-by: DL6ER <dl6er@dl6er.de>
2020-04-25 07:02:37 +02:00
DL6ER 77b421b133 Show how many domains have been added in case of an error.
Signed-off-by: DL6ER <dl6er@dl6er.de>
2020-04-23 13:47:50 +02:00
DL6ER 7d1163ff9c Try to be clearer with the "failed to add domain" message by showing the original input when idn_to_ascii() failed and by showing both, the original and the converted domain when the conversion result itself is invalid.
Signed-off-by: DL6ER <dl6er@dl6er.de>
2020-04-23 11:39:57 +02:00
DL6ER 14dd1350df Strip whitespaces from the beginning and end of user input to prevent errors getting triggered due to users trying to add "empty" domains.
Signed-off-by: DL6ER <dl6er@dl6er.de>
2020-04-23 11:27:24 +02:00
DL6ER c49bcb1454 Merge pull request #1147 from Th3M3/fix/custom_tooltips
tweak chartjs customtooltips
2020-04-21 16:34:19 +02:00
DL6ER c1ddf66487 Merge pull request #1206 from pi-hole/fix/dhcp_static_error
Check for existence and readability of static leases file before trying to access it
2020-04-21 10:07:15 +02:00
DL6ER 2e7b9191fc Update scripts/pi-hole/js/queries.js
Co-Authored-By: TheME <andreas_fl@outlook.com>
2020-04-14 19:54:43 +02:00
DL6ER 8ad3b70f96 We should also accept open-ended IPv6 addresses such as, e.g., fda2:2001:5555::
Signed-off-by: DL6ER <dl6er@dl6er.de>
2020-04-13 09:48:08 +02:00
Th3M3 fadc6073db tweak chartjs customtooltips...
...and disable 'maintainAspectRatio' for the clients chart to avoid a squeezed display on small screens.

Signed-off-by: Th3M3 <the_me@outlook.de>
2020-04-12 15:25:29 +02:00
DL6ER 0f21f6d269 Release possible previous onClick event handler on regex links to avoid multiple tabs being opened on click.
Signed-off-by: DL6ER <dl6er@dl6er.de>
2020-04-10 10:45:26 +02:00
DL6ER 0f892c9ffc Check for existance and readability of static leases file before trying to access it.
Signed-off-by: DL6ER <dl6er@dl6er.de>
2020-04-07 12:30:51 +02:00
Th3M3 3ea59d5d36 shorter button textes & cleanup
Signed-off-by: Th3M3 <the_me@outlook.de>
2020-04-05 20:49:53 +02:00
Th3M3 fd983a2b68 improve multiselect
Signed-off-by: Th3M3 <the_me@outlook.de>
2020-04-05 14:56:28 +02:00
DL6ER 0a81dadf2f Merge pull request #1161 from pi-hole/tweak/wrap_other_tables
Add class "breakall" also to the code fields in the other tables.
2020-03-31 23:43:25 +02:00
DL6ER f9fd89cda7 Merge pull request #1149 from pi-hole/new/space-separated-item-injection
Allow space separated multiple items injection
2020-03-31 23:40:39 +02:00
DL6ER 57e139bcba Merge branch 'release/v5.0' into new/space-separated-item-injection 2020-03-31 21:31:41 +00:00
DL6ER 1e22f3349f Merge branch 'release/v5.0' into fix/queries_over_time 2020-03-31 21:22:18 +00:00
DL6ER 6e98c41a4f Merge branch 'release/v5.0' into tweak/wrap_other_tables 2020-03-31 21:11:30 +00:00
DL6ER 7d2d9c29db Merge pull request #1199 from pi-hole/tweak/remember_filtering_chkbox
Remember last state of the "Apply filtering" checkbox on the Query Log page
2020-03-31 23:08:09 +02:00
DL6ER e2ca6bc920 Merge pull request #1187 from pi-hole/new/all_clients_network_table
Hide mock hardware addresses
2020-03-31 23:07:59 +02:00
Adam Warner 1dbbd3583c Merge pull request #1190 from Th3M3/fix/allow_empty_emailaddress
allow to clear email address
2020-03-31 22:07:13 +01:00
DL6ER f0034b305d Check adlist URL for valid characters before adding record to the database.
Signed-off-by: DL6ER <dl6er@dl6er.de>
2020-03-31 20:41:50 +00:00
DL6ER e328f51e17 Remember last state of the "Apply filtering" checkbox on the Query Log page. Store this browser- not server-wise so individual users can use their own prefered settings.
Signed-off-by: DL6ER <dl6er@dl6er.de>
2020-03-31 20:20:17 +00:00
DL6ER 6fdeee53ca Merge pull request #1181 from pi-hole/tweak/client_address_validation
Add IPv4/IPv6 address validation to clients management page
2020-03-28 15:02:35 +01:00
Th3M3 2a38bcc074 allow to clear email address
Signed-off-by: Th3M3 <the_me@outlook.de>
2020-03-18 21:39:55 +01:00
DL6ER bc9c656e37 Improve domain pages (#1184)
* Split domain input into two separate fields.

* Codestyle changes

* Fix checkout layout on full/limited domain pages.

* Improve wildcard hint

Signed-off-by: DL6ER <dl6er@dl6er.de>


* tabs for new domain/regex input

Signed-off-by: Th3M3 <the_me@outlook.de>


Co-authored-by: TheME <andreas_fl@outlook.com>
2020-03-15 12:07:22 -07:00
DL6ER ded679a9b7 Add IPv4/IPv6 address validation to clients management page
Signed-off-by: DL6ER <dl6er@dl6er.de>
2020-03-14 13:37:33 +00:00
DL6ER a99bfeaa6c Set hostname to italic unknown if not available
Signed-off-by: DL6ER <dl6er@dl6er.de>
2020-03-12 19:27:08 +00:00
DL6ER d89b13cf6c Hide mock hardware addresses
Signed-off-by: DL6ER <dl6er@dl6er.de>
2020-03-12 19:25:43 +00:00
Adam Warner 49da88949c Merge pull request #1074 from XhmikosR/favicons
New favicons.
2020-03-11 19:41:46 +00:00
Dan Schaper aa51f014ab Fix domain and group disassociation when toggling from Black/Whitelis… (#1172)
* Fix domain and group disassociation when toggling from Black/Whitelist page

* Properly set the groups variable

Signed-off-by: trillaxe <trillax@tutanota.com>

* Trim whitespace

Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net>
2020-03-05 12:59:42 -08:00
DL6ER 2530db8944 Responsiveness improvements for audit log page.
Signed-off-by: DL6ER <dl6er@dl6er.de>
2020-02-22 12:35:04 +01:00
DL6ER 214bb004db Merge branch 'release/v5.0' into fix/audit_log 2020-02-22 11:43:43 +01:00
TheME 9fde58d7e0 make id names unique, ...* (#1170)
* - remove unneeded code
- fix php notice in log if url parameter 'type' is not set

Signed-off-by: Th3M3 the_me@outlook.de
2020-02-21 12:04:51 -08:00
DL6ER 1300b5411a Fix audit log page.
Signed-off-by: DL6ER <dl6er@dl6er.de>
2020-02-21 19:11:17 +01:00
DL6ER ea6a6ad2f3 Keep "custom" selection after clicking [Add].
Signed-off-by: DL6ER <dl6er@dl6er.de>
2020-02-21 18:27:39 +01:00
DL6ER 59085c237e Merge branch 'release/v5.0' into new/clients_comment_fields
Signed-off-by: DL6ER <dl6er@dl6er.de>
2020-02-18 16:44:12 +01:00
Adam Warner 4e27eba0d2 Merge pull request #1159 from pi-hole/fix/group_assignment_allow_overflow
Enable visibility of overflow in table-responsive
2020-02-17 15:11:27 +00:00
DL6ER 7274b9bca7 Only use IDN subroutines when the module is available. We have seen reports that at least DietPi is having issues with not matching PHP base and extension versions.
Signed-off-by: DL6ER <dl6er@dl6er.de>
2020-02-16 21:16:06 +01:00
Adam Warner 596f5af7fa Merge branch 'release/v5.0' into fix/group_assignment_allow_overflow 2020-02-16 18:51:29 +00:00
Adam Warner 211bcc999f Whejn dropdown is shown, move it outside of the datatable container (at the same absolute position)
When it is closed, put it back where it came from

Signed-off-by: Adam Warner <me@adamwarner.co.uk>
2020-02-16 17:33:52 +00:00