From caef160c5551ffbde9ae6b344a5dfe3822bb376c Mon Sep 17 00:00:00 2001 From: DL6ER Date: Sun, 19 Nov 2023 11:39:33 +0100 Subject: [PATCH 1/4] Add HTTP 403 error page Signed-off-by: DL6ER --- error403.lp | 26 ++++++++++++++++++++++++++ 1 file changed, 26 insertions(+) create mode 100644 error403.lp diff --git a/error403.lp b/error403.lp new file mode 100644 index 00000000..d071669f --- /dev/null +++ b/error403.lp @@ -0,0 +1,26 @@ + + + + + From a4b7537ae1fdd9f5c490cbf164b61cc24527dedf Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Christian=20K=C3=B6nig?= Date: Sun, 19 Nov 2023 20:55:54 +0000 Subject: [PATCH 2/4] Fix deleting sessions via red trash icon MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Christian König --- scripts/pi-hole/js/settings-api.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/pi-hole/js/settings-api.js b/scripts/pi-hole/js/settings-api.js index cde5858a..251af7ef 100644 --- a/scripts/pi-hole/js/settings-api.js +++ b/scripts/pi-hole/js/settings-api.js @@ -191,7 +191,7 @@ $(function () { function deleteThisSession() { // This function is called when a red trash button is clicked // We get the ID of the current item from the data-del-id attribute - const thisID = parseInt(this.attr("data-del-id"), 10); + const thisID = parseInt($(this).attr("data-del-id"), 10); deleted = 0; deleteOneSession(thisID, 1, false); } From 3b5cfd7d6e669cf6b122f7f5a2ac515e799c0e6b Mon Sep 17 00:00:00 2001 From: RD WebDesign Date: Sun, 19 Nov 2023 18:04:39 -0300 Subject: [PATCH 3/4] Change the `text-danger` color to increase the contrast The issue only affects one theme: High Contrast Dark Signed-off-by: RD WebDesign --- style/themes/high-contrast-dark.css | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/style/themes/high-contrast-dark.css b/style/themes/high-contrast-dark.css index f529132e..354eb8f4 100644 --- a/style/themes/high-contrast-dark.css +++ b/style/themes/high-contrast-dark.css @@ -483,6 +483,11 @@ kbd { color: #808890; } +/* Used in error403 */ +.text-danger { + color: #f54; +} + .warning-count { color: #000; background: #f94; From a518b60afedf66d23073a8a88066835e309f1797 Mon Sep 17 00:00:00 2001 From: DL6ER Date: Sun, 19 Nov 2023 23:02:12 +0100 Subject: [PATCH 4/4] Show Unicode domains (if different from possibly punycode-encoded raw domains) Signed-off-by: DL6ER --- scripts/pi-hole/js/groups-domains.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/scripts/pi-hole/js/groups-domains.js b/scripts/pi-hole/js/groups-domains.js index 4f912df1..22248d45 100644 --- a/scripts/pi-hole/js/groups-domains.js +++ b/scripts/pi-hole/js/groups-domains.js @@ -151,7 +151,8 @@ function initTable() { '" title="' + tooltip + '" class="breakall">' + - data.domain + + data.unicode + + (data.domain !== data.unicode ? " (" + data.domain + ")" : "") + "" );