From fb2a8cffa9788838450ec903a090fd15f4491edc Mon Sep 17 00:00:00 2001 From: DL6ER Date: Fri, 1 Dec 2023 09:45:47 +0100 Subject: [PATCH] Apply expert settings even there is no #expert-settings element on this page Signed-off-by: DL6ER --- scripts/pi-hole/js/footer.js | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/scripts/pi-hole/js/footer.js b/scripts/pi-hole/js/footer.js index 0a518ee1..b53089a6 100644 --- a/scripts/pi-hole/js/footer.js +++ b/scripts/pi-hole/js/footer.js @@ -648,8 +648,11 @@ $("#pihole-disable-custom").on("click", function (e) { function initSettingsLevel() { const elem = $("#expert-settings"); - // Skip if element is not present (e.g. on login page) - if (elem.length === 0) return; + // Skip init if element is not present (e.g. on login page) + if (elem.length === 0) { + applyExpertSettings(); + return; + } // Restore settings level from local storage (if available) or default to "false" if (localStorage.getItem("expert_settings") === null) { @@ -680,6 +683,10 @@ function initSettingsLevel() { } function applyExpertSettings() { + // Apply settings level, this will hide/show elements with the class + // "settings-level-basic" or "settings-level-expert" depending on the + // current settings level + // If "expert_settings" is not set, we default to !"true" (basic settings) if (localStorage.getItem("expert_settings") === "true") { $(".settings-level-basic").show(); $(".settings-level-expert").show();