From 127314e98e4401b41ff8b73bacd57fe7b20813e4 Mon Sep 17 00:00:00 2001 From: Mcat12 Date: Tue, 8 Aug 2017 20:46:01 -0400 Subject: [PATCH 1/2] Fix undefined total in DB top lists --- scripts/pi-hole/js/db_lists.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/scripts/pi-hole/js/db_lists.js b/scripts/pi-hole/js/db_lists.js index 9a7cdfbc..00087d75 100644 --- a/scripts/pi-hole/js/db_lists.js +++ b/scripts/pi-hole/js/db_lists.js @@ -90,7 +90,7 @@ function updateTopClientsChart() { var url = clientname; percentage = data.top_sources[client] / sum * 100.0; clienttable.append(" " + url + - " " + data.top_sources[client] + "
" + data.top_sources[client] + "
"); } @@ -108,7 +108,7 @@ function updateTopDomainsChart() { $("#domain-frequency td").parent().remove(); var domaintable = $("#domain-frequency").find("tbody:last"); var domain, percentage; - var sum = 0; + let sum = 0; for (domain in data.top_domains) { if ({}.hasOwnProperty.call(data.top_domains, domain)){ sum += data.top_domains[domain]; @@ -128,7 +128,7 @@ function updateTopDomainsChart() { percentage = data.top_domains[domain] / sum * 100.0; domaintable.append(" " + domain + - " " + data.top_domains[domain] + "
" + data.top_domains[domain] + "
"); } @@ -165,7 +165,7 @@ function updateTopAdsChart() { } percentage = data.top_ads[ad] / sum * 100.0; - adtable.append(" " + ad + " " + data.top_ads[ad] + "
"); + adtable.append(" " + ad + " " + data.top_ads[ad] + "
"); } } From cff98f8ebe346e985cf2834b87e9454d9b29cf0a Mon Sep 17 00:00:00 2001 From: Mcat12 Date: Tue, 8 Aug 2017 20:49:31 -0400 Subject: [PATCH 2/2] Remove testing change --- scripts/pi-hole/js/db_lists.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/pi-hole/js/db_lists.js b/scripts/pi-hole/js/db_lists.js index 00087d75..75a21746 100644 --- a/scripts/pi-hole/js/db_lists.js +++ b/scripts/pi-hole/js/db_lists.js @@ -108,7 +108,7 @@ function updateTopDomainsChart() { $("#domain-frequency td").parent().remove(); var domaintable = $("#domain-frequency").find("tbody:last"); var domain, percentage; - let sum = 0; + var sum = 0; for (domain in data.top_domains) { if ({}.hasOwnProperty.call(data.top_domains, domain)){ sum += data.top_domains[domain];