From b2572c07e5b0802efa95c3a7702694dbb4a6e7fe Mon Sep 17 00:00:00 2001
From: Adam Warner <me@adamwarner.co.uk>
Date: Sat, 28 Oct 2023 17:28:32 +0100
Subject: [PATCH] The CI does not like nested IF statements with a single
 action inside

Signed-off-by: Adam Warner <me@adamwarner.co.uk>
---
 scripts/pi-hole/js/settings.js | 20 ++++++++------------
 1 file changed, 8 insertions(+), 12 deletions(-)

diff --git a/scripts/pi-hole/js/settings.js b/scripts/pi-hole/js/settings.js
index 660bb56a..15ed59f0 100644
--- a/scripts/pi-hole/js/settings.js
+++ b/scripts/pi-hole/js/settings.js
@@ -39,20 +39,16 @@ function setConfigValues(topic, key, value) {
   var escapedKey = key.replaceAll(".", "\\.");
   var envTitle = $(`.${escapedKey}`);
 
-  if (value.flags.advanced) {
-    if (envTitle.find(".advanced-warning").length === 0) {
-      envTitle.append(
-        `<span class="advanced-warning">&nbsp;&nbsp;<i class="fas fa-wrench" title="This is an advanced level setting"></i></span>`
-      );
-    }
+  if (value.flags.advanced && envTitle.find(".advanced-warning").length === 0) {
+    envTitle.append(
+      `<span class="advanced-warning">&nbsp;&nbsp;<i class="fas fa-wrench" title="This is an advanced level setting"></i></span>`
+    );
   }
 
-  if (value.flags.restart_dnsmasq) {
-    if (envTitle.find(".restart-warning").length === 0) {
-      envTitle.append(
-        `<span class="restart-warning">&nbsp;&nbsp;<i class="fas fa-redo text-orange" title="Setting requires FTL restart on change"></i></span>`
-      );
-    }
+  if (value.flags.restart_dnsmasq && envTitle.find(".restart-warning").length === 0) {
+    envTitle.append(
+      `<span class="restart-warning">&nbsp;&nbsp;<i class="fas fa-redo text-orange" title="Setting requires FTL restart on change"></i></span>`
+    );
   }
 
   if (value.flags.env_var) {