From 9be0c610503569fb92bf5537df3c356a60bb7456 Mon Sep 17 00:00:00 2001
From: DL6ER <dl6er@dl6er.de>
Date: Mon, 28 Dec 2020 10:56:11 +0100
Subject: [PATCH] Always inform about any invalid domains on a list using
 exclamation-triangle and bold-red text in the invalid domains column

Signed-off-by: DL6ER <dl6er@dl6er.de>
---
 scripts/pi-hole/js/groups-adlists.js | 20 +++++++++++++++++---
 1 file changed, 17 insertions(+), 3 deletions(-)

diff --git a/scripts/pi-hole/js/groups-adlists.js b/scripts/pi-hole/js/groups-adlists.js
index 39000dcd..e7c9d054 100644
--- a/scripts/pi-hole/js/groups-adlists.js
+++ b/scripts/pi-hole/js/groups-adlists.js
@@ -67,6 +67,11 @@ function format(data) {
     }
   }
 
+  var invalidStyle =
+    data.invalid_domains !== null && numbers === true
+      ? ' style="color:red; font-weight:bold;"'
+      : "";
+
   // Compile extra info for displaying
   return (
     "<table>" +
@@ -89,7 +94,10 @@ function format(data) {
       : "N/A") +
     '</td></tr><tr class="dataTables-child"><td>Number of valid domains on this list:&nbsp;&nbsp;</td><td>' +
     (data.number !== null && numbers === true ? data.number : "N/A") +
-    '</td></tr><tr class="dataTables-child"><td>Number of invalid domains on this list:&nbsp;&nbsp;</td><td>' +
+    '</td></tr><tr class="dataTables-child"' +
+    invalidStyle +
+    "><td>Number of invalid domains on this list:&nbsp;&nbsp;</td>" +
+    "<td>" +
     (data.invalid_domains !== null && numbers === true ? data.invalid_domains : "N/A") +
     '</td></tr><tr class="dataTables-child"><td>Database ID of this list:</td><td>' +
     data.id +
@@ -131,7 +139,6 @@ function initTable() {
         statusCode = parseInt(data.status, 10);
       }
 
-      $("td:eq(0)", row).addClass("list-status-" + statusCode);
       switch (statusCode) {
         default:
         case 0:
@@ -151,7 +158,14 @@ function initTable() {
           break;
       }
 
-      $("td:eq(0)", row).html("<i class='fa " + statusIcon + "'></i>");
+      // Always overwrite icon with red exclamation-triangle when there are invalid lines in a list
+      var extra = "";
+      if (data.invalid_domains !== null && data.invalid_domains > 0) {
+        extra = "<i class='fa fa-exclamation-triangle list-status-3'></i>";
+      }
+
+      $("td:eq(0)", row).addClass("list-status-" + statusCode);
+      $("td:eq(0)", row).html("<i class='fa " + statusIcon + "'></i>" + extra);
 
       $("td:eq(1)", row).html(
         '<a id="address_' +