From 8e4e4754c424696c701b73b40ac59cedc0d935a8 Mon Sep 17 00:00:00 2001 From: DL6ER Date: Sat, 4 Nov 2023 13:07:36 +0100 Subject: [PATCH] Show human-readable error message on settings save fail Signed-off-by: DL6ER --- scripts/pi-hole/js/settings.js | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/scripts/pi-hole/js/settings.js b/scripts/pi-hole/js/settings.js index b94f0074..bd10a45a 100644 --- a/scripts/pi-hole/js/settings.js +++ b/scripts/pi-hole/js/settings.js @@ -114,6 +114,7 @@ function setConfigValues(topic, key, value) { function saveSettings() { var settings = {}; + utils.disableAll(); $("[data-key]").each(function () { var key = $(this).data("key"); var value = $(this).val(); @@ -168,6 +169,7 @@ function saveSettings() { contentType: "application/json; charset=utf-8", }) .done(function () { + utils.enableAll(); // Success utils.showAlert( "success", @@ -178,7 +180,10 @@ function saveSettings() { // Reload page location.reload(); }) - .fail(function (data) { + .fail(function (data, exception) { + utils.enableAll(); + utils.showAlert("error", "", "Error while applying settings", data.responseText); + console.log(exception); // eslint-disable-line no-console apiFailure(data); }); }