From 7c1c45dbbd27d8de5c3a9fd0bccfcb18632017fb Mon Sep 17 00:00:00 2001
From: DL6ER <derigs@ph1.uni-koeln.de>
Date: Sun, 11 Dec 2016 18:34:02 +0100
Subject: [PATCH] Simplified IP address validation

---
 php/savesettings.php | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/php/savesettings.php b/php/savesettings.php
index 6957f895..c8ee5d1a 100644
--- a/php/savesettings.php
+++ b/php/savesettings.php
@@ -1,4 +1,9 @@
 <?php
+
+function validIP($ip){
+	return filter_var($secondaryIP, FILTER_VALIDATE_IP, FILTER_FLAG_IPV4) === false;
+}
+
 	$debug = $_POST;
 
 	$primaryDNSservers = [
@@ -37,7 +42,7 @@
 				}
 
 				// Validate primary IP
-				if (!filter_var($primaryIP, FILTER_VALIDATE_IP, FILTER_FLAG_IPV4) === true)
+				if (!validIP($primaryIP))
 				{
 					$error = "Primary IP (".$primaryIP.") is invalid!";
 				}
@@ -53,7 +58,7 @@
 				}
 
 				// Validate secondary IP
-				if (!filter_var($secondaryIP, FILTER_VALIDATE_IP, FILTER_FLAG_IPV4) === true)
+				if (!validIP($secondaryIP))
 				{
 					$error = "Secondary IP (".$secondaryIP.") is invalid!";
 				}