diff --git a/scripts/pi-hole/js/db_queries.js b/scripts/pi-hole/js/db_queries.js index efa85074..3feafb85 100644 --- a/scripts/pi-hole/js/db_queries.js +++ b/scripts/pi-hole/js/db_queries.js @@ -233,24 +233,35 @@ $(function () { var replyid = parseInt(data[6], 10); var dnssecStatus; switch (data[8]) { - case 1: + case 1: { dnssecStatus = '
SECURE'; break; - case 2: + } + + case 2: { dnssecStatus = '
INSECURE'; break; - case 3: + } + + case 3: { dnssecStatus = '
BOGUS'; break; - case 4: + } + + case 4: { dnssecStatus = '
ABANDONED'; break; - case 5: + } + + case 5: { dnssecStatus = '
UNKNOWN'; break; - default: + } + + default: { // No DNSSEC dnssecStatus = ""; + } } if (dnssecStatus.length > 0) { @@ -262,13 +273,15 @@ $(function () { buttontext = "", blocked = false; switch (data[4]) { - case 1: + case 1: { fieldtext = "Blocked (gravity)"; buttontext = ''; blocked = true; break; - case 2: + } + + case 2: { fieldtext = replyid === 0 ? "OK (sent to " @@ -277,91 +290,124 @@ $(function () { buttontext = ''; break; - case 3: + } + + case 3: { fieldtext = "OK (cache)" + dnssecStatus; buttontext = ''; break; - case 4: + } + + case 4: { fieldtext = "Blocked (regex blacklist)"; buttontext = ''; blocked = true; break; - case 5: + } + + case 5: { fieldtext = "Blocked (exact blacklist)"; buttontext = ''; blocked = true; break; - case 6: + } + + case 6: { fieldtext = "Blocked (external, IP)"; blocked = true; break; - case 7: + } + + case 7: { fieldtext = "Blocked (external, NULL)"; blocked = true; break; - case 8: + } + + case 8: { fieldtext = "Blocked (external, NXRA)"; blocked = true; break; - case 9: + } + + case 9: { fieldtext = "Blocked (gravity, CNAME)"; buttontext = ''; blocked = true; break; - case 10: + } + + case 10: { fieldtext = "Blocked (regex blacklist, CNAME)"; buttontext = ''; blocked = true; break; - case 11: + } + + case 11: { fieldtext = "Blocked (exact blacklist, CNAME)"; buttontext = ''; blocked = true; break; - case 12: + } + + case 12: { fieldtext = "Retried"; break; - case 13: + } + + case 13: { fieldtext = "Retried (ignored)"; break; - case 14: + } + + case 14: { fieldtext = "OK (already forwarded)" + dnssecStatus; buttontext = ''; break; - case 15: + } + + case 15: { fieldtext = "Blocked (database is busy)"; blocked = true; break; - case 16: + } + + case 16: { fieldtext = "Blocked (special domain)"; blocked = true; break; - case 17: + } + + case 17: { fieldtext = "OK (stale cache)" + dnssecStatus; buttontext = ''; break; - default: + } + + default: { fieldtext = "Unknown (" + parseInt(data[4], 10) + ")"; + } } // Cannot block internal queries of this type diff --git a/scripts/pi-hole/js/footer.js b/scripts/pi-hole/js/footer.js index 73ab2107..fc4836fb 100644 --- a/scripts/pi-hole/js/footer.js +++ b/scripts/pi-hole/js/footer.js @@ -23,18 +23,20 @@ function piholeChanged(action) { var dis = $("#pihole-disable"); switch (action) { - case "enabled": + case "enabled": { status.html(" Active"); ena.hide(); dis.show(); dis.removeClass("active"); break; + } - case "disabled": + case "disabled": { status.html(" Blocking disabled"); ena.show(); dis.hide(); break; + } default: // nothing @@ -71,7 +73,7 @@ function piholeChange(action, duration) { var btnStatus; switch (action) { - case "enable": + case "enable": { btnStatus = $("#flip-status-enable"); btnStatus.html(" "); $.getJSON("api.php?enable&token=" + token, function (data) { @@ -81,8 +83,9 @@ function piholeChange(action, duration) { } }); break; + } - case "disable": + case "disable": { btnStatus = $("#flip-status-disable"); btnStatus.html(" "); $.getJSON("api.php?disable=" + duration + "&token=" + token, function (data) { @@ -96,6 +99,7 @@ function piholeChange(action, duration) { } }); break; + } default: // nothing @@ -168,19 +172,22 @@ function initCPUtemp() { var displaytemp = $("#tempdisplay"); if (!isNaN(temperature)) { switch (unit) { - case "K": + case "K": { temperature += 273.15; displaytemp.html(temperature.toFixed(1) + " K"); break; + } - case "F": + case "F": { temperature = (temperature * 9) / 5 + 32; displaytemp.html(temperature.toFixed(1) + " °F"); break; + } - default: + default: { displaytemp.html(temperature.toFixed(1) + " °C"); break; + } } } } diff --git a/scripts/pi-hole/js/groups-adlists.js b/scripts/pi-hole/js/groups-adlists.js index e8e9cb2c..06c4d5a3 100644 --- a/scripts/pi-hole/js/groups-adlists.js +++ b/scripts/pi-hole/js/groups-adlists.js @@ -44,34 +44,44 @@ function format(data) { var numbers = true; if (data.status !== null) { switch (parseInt(data.status, 10)) { - case 0: + case 0: { statusText = data.enabled === 0 ? "List is disabled and not checked" : "List was not downloaded so far"; numbers = false; break; - case 1: + } + + case 1: { statusText = 'List download was successful (OK)'; break; - case 2: + } + + case 2: { statusText = 'List unchanged upstream, Pi-hole used a local copy (OK)'; break; - case 3: + } + + case 3: { statusText = 'List unavailable, Pi-hole used a local copy (check list)'; break; - case 4: + } + + case 4: { statusText = 'List unavailable, there is no local copy of this list available on your Pi-hole (replace list)'; numbers = false; break; + } - default: + default: { statusText = 'Unknown (' + parseInt(data.status, 10) + ")"; break; + } } } @@ -168,21 +178,30 @@ function initTable() { } switch (statusCode) { - case 1: + case 1: { statusIcon = "fa-check"; break; - case 2: + } + + case 2: { statusIcon = "fa-history"; break; - case 3: + } + + case 3: { statusIcon = "fa-exclamation-circle"; break; - case 4: + } + + case 4: { statusIcon = "fa-times"; break; - default: + } + + default: { statusIcon = "fa-question-circle"; break; + } } // Append red exclamation-triangle when there are invalid lines on the list @@ -567,7 +586,7 @@ function editAdlist() { var done = "edited"; var notDone = "editing"; switch (elem) { - case "status_" + id: + case "status_" + id: { if (status === 0) { done = "disabled"; notDone = "disabling"; @@ -577,17 +596,24 @@ function editAdlist() { } break; - case "comment_" + id: + } + + case "comment_" + id: { done = "edited comment of"; notDone = "editing comment of"; break; - case "multiselect_" + id: + } + + case "multiselect_" + id: { done = "edited groups of"; notDone = "editing groups of"; break; - default: + } + + default: { alert("bad element or invalid data-id!"); return; + } } utils.disableAll(); diff --git a/scripts/pi-hole/js/groups-clients.js b/scripts/pi-hole/js/groups-clients.js index ec77bc61..52c12391 100644 --- a/scripts/pi-hole/js/groups-clients.js +++ b/scripts/pi-hole/js/groups-clients.js @@ -467,17 +467,22 @@ function editClient() { var done = "edited"; var notDone = "editing"; switch (elem) { - case "multiselect_" + id: + case "multiselect_" + id: { done = "edited groups of"; notDone = "editing groups of"; break; - case "comment_" + id: + } + + case "comment_" + id: { done = "edited comment of"; notDone = "editing comment of"; break; - default: + } + + default: { alert("bad element or invalid data-id!"); return; + } } if (name.length > 0) { diff --git a/scripts/pi-hole/js/groups-domains.js b/scripts/pi-hole/js/groups-domains.js index f1228dd5..c681a6f6 100644 --- a/scripts/pi-hole/js/groups-domains.js +++ b/scripts/pi-hole/js/groups-domains.js @@ -596,7 +596,7 @@ function editDomain() { var done = "edited"; var notDone = "editing"; switch (elem) { - case "status_" + id: + case "status_" + id: { if (status === 0) { done = "disabled"; notDone = "disabling"; @@ -606,25 +606,36 @@ function editDomain() { } break; - case "name_" + id: + } + + case "name_" + id: { done = "edited name of"; notDone = "editing name of"; break; - case "comment_" + id: + } + + case "comment_" + id: { done = "edited comment of"; notDone = "editing comment of"; break; - case "type_" + id: + } + + case "type_" + id: { done = "edited type of"; notDone = "editing type of"; break; - case "multiselect_" + id: + } + + case "multiselect_" + id: { done = "edited groups of"; notDone = "editing groups of"; break; - default: + } + + default: { alert("bad element or invalid data-id!"); return; + } } utils.disableAll(); diff --git a/scripts/pi-hole/js/groups.js b/scripts/pi-hole/js/groups.js index 8f21d460..27d5a493 100644 --- a/scripts/pi-hole/js/groups.js +++ b/scripts/pi-hole/js/groups.js @@ -312,7 +312,7 @@ function editGroup() { var done = "edited"; var notDone = "editing"; switch (elem) { - case "status_" + id: + case "status_" + id: { if (status === 0) { done = "disabled"; notDone = "disabling"; @@ -322,17 +322,24 @@ function editGroup() { } break; - case "name_" + id: + } + + case "name_" + id: { done = "edited name of"; notDone = "editing name of"; break; - case "desc_" + id: + } + + case "desc_" + id: { done = "edited description of"; notDone = "editing description of"; break; - default: + } + + default: { alert("bad element or invalid data-id!"); return; + } } utils.disableAll(); diff --git a/scripts/pi-hole/js/index.js b/scripts/pi-hole/js/index.js index 430385ae..f079c567 100644 --- a/scripts/pi-hole/js/index.js +++ b/scripts/pi-hole/js/index.js @@ -123,7 +123,7 @@ var customTooltips = function (context) { tooltipX = offsetX + caretX; if (tooltip.yAlign === "top" || tooltip.yAlign === "bottom") { switch (tooltip.xAlign) { - case "center": + case "center": { // set a minimal X position to 5px to prevent // the tooltip to stick out left of the viewport var minX = 5; @@ -135,30 +135,44 @@ var customTooltips = function (context) { } break; - case "left": + } + + case "left": { tooltipX -= arrowMinIndent; arrowX = arrowMinIndent; break; - case "right": + } + + case "right": { tooltipX -= tooltipWidth - arrowMinIndent; arrowX = tooltipWidth - arrowMinIndent; break; - default: + } + + default: { break; + } } } else if (tooltip.yAlign === "center") { switch (tooltip.xAlign) { - case "left": + case "left": { tooltipX += caretPadding; break; - case "right": + } + + case "right": { tooltipX -= tooltipWidth - caretPadding; break; - case "center": + } + + case "center": { tooltipX -= tooltipWidth / 2; break; - default: + } + + default: { break; + } } } } else { @@ -179,10 +193,12 @@ var customTooltips = function (context) { // Compute Y position switch (tooltip.yAlign) { - case "top": + case "top": { tooltipY = offsetY + caretY + arrowSize + caretPadding; break; - case "center": + } + + case "center": { tooltipY = offsetY + caretY - tooltipHeight / 2; if (tooltip.xAlign === "left") { tooltipX += arrowSize; @@ -191,11 +207,16 @@ var customTooltips = function (context) { } break; - case "bottom": + } + + case "bottom": { tooltipY = offsetY + caretY - tooltipHeight - arrowSize - caretPadding; break; - default: + } + + default: { break; + } } // Position tooltip and display diff --git a/scripts/pi-hole/js/messages.js b/scripts/pi-hole/js/messages.js index a480d550..ceb75543 100644 --- a/scripts/pi-hole/js/messages.js +++ b/scripts/pi-hole/js/messages.js @@ -26,7 +26,7 @@ function multiline(input) { function renderMessage(data, type, row) { // Display and search content switch (row.type) { - case "REGEX": + case "REGEX": { return ( 'Encountered an error when processing " ); + } - case "SUBNET": + case "SUBNET": { return ( "Client " + row.message + @@ -56,8 +57,9 @@ function renderMessage(data, type, row) { row.blob4 + " to get the group configuration for this client." ); + } - case "HOSTNAME": + case "HOSTNAME": { // eslint-disable-next-line unicorn/no-new-array var hint = new Array(row.blob2 + row.message.length + 3).join(" "); return ( @@ -73,11 +75,13 @@ function renderMessage(data, type, row) { hint + "↑" ); + } - case "DNSMASQ_CONFIG": + case "DNSMASQ_CONFIG": { return "FTL failed to start due to " + row.message; + } - case "RATE_LIMIT": + case "RATE_LIMIT": { return ( "Client " + row.message + @@ -87,15 +91,17 @@ function renderMessage(data, type, row) { parseInt(row.blob2, 10) + " seconds)" ); + } - case "DNSMASQ_WARN": + case "DNSMASQ_WARN": { return ( "Warning in dnsmasq core:
" +
         row.message +
         '
Check out
our documentation for further information.' ); + } - case "LOAD": + case "LOAD": { return ( "Long-term load (15min avg) larger than number of processors: " + parseFloat(row.blob1).toFixed(1) + @@ -103,8 +109,9 @@ function renderMessage(data, type, row) { parseInt(row.blob2, 10) + "
This may slow down DNS resolution and can cause bottlenecks." ); + } - case "SHMEM": + case "SHMEM": { return ( "RAM shortage (" + utils.escapeHtml(row.message) + @@ -114,8 +121,9 @@ function renderMessage(data, type, row) { utils.escapeHtml(row.blob2) + "" ); + } - case "DISK": + case "DISK": { return ( "Disk shortage (" + utils.escapeHtml(row.message) + @@ -125,8 +133,9 @@ function renderMessage(data, type, row) { utils.escapeHtml(row.blob2) + "" ); + } - case "ADLIST": + case "ADLIST": { return ( '" ); + } - default: + default: { return "Unknown message type
" + JSON.stringify(row) + "
"; + } } } diff --git a/scripts/pi-hole/js/queries.js b/scripts/pi-hole/js/queries.js index 163d282b..6ba8d29c 100644 --- a/scripts/pi-hole/js/queries.js +++ b/scripts/pi-hole/js/queries.js @@ -80,26 +80,37 @@ $(function () { var replyid = parseInt(data[5], 10); // DNSSEC status var dnssecStatus; - var ede = data[11] ? data[11] : ""; + var ede = data[11] ?? ""; switch (data[6]) { - case "1": + case "1": { dnssecStatus = '
SECURE'; break; - case "2": + } + + case "2": { dnssecStatus = '
INSECURE'; break; - case "3": + } + + case "3": { dnssecStatus = '
BOGUS'; break; - case "4": + } + + case "4": { dnssecStatus = '
ABANDONED'; break; - case "5": + } + + case "5": { dnssecStatus = '
UNKNOWN'; break; - default: + } + + default: { // No DNSSEC dnssecStatus = ""; + } } if (dnssecStatus.length > 0) { @@ -121,13 +132,15 @@ $(function () { } switch (data[4]) { - case "1": + case "1": { fieldtext = "Blocked (gravity)"; buttontext = ''; blocked = true; break; - case "2": + } + + case "2": { fieldtext = replyid === 0 ? "OK (sent to " @@ -137,42 +150,57 @@ $(function () { buttontext = ''; break; - case "3": + } + + case "3": { fieldtext = "OK (cache)" + dnssecStatus; buttontext = ''; break; - case "4": - fieldtext = "Blocked (regex blacklist)"; + } + + case "4": { + fieldtext = + "Blocked