"
);
+ }
- default:
+ default: {
return "Unknown message type" + JSON.stringify(row) + "
";
+ }
}
}
diff --git a/scripts/pi-hole/js/queries.js b/scripts/pi-hole/js/queries.js
index 163d282b..6ba8d29c 100644
--- a/scripts/pi-hole/js/queries.js
+++ b/scripts/pi-hole/js/queries.js
@@ -80,26 +80,37 @@ $(function () {
var replyid = parseInt(data[5], 10);
// DNSSEC status
var dnssecStatus;
- var ede = data[11] ? data[11] : "";
+ var ede = data[11] ?? "";
switch (data[6]) {
- case "1":
+ case "1": {
dnssecStatus = '
SECURE';
break;
- case "2":
+ }
+
+ case "2": {
dnssecStatus = '
INSECURE';
break;
- case "3":
+ }
+
+ case "3": {
dnssecStatus = '
BOGUS';
break;
- case "4":
+ }
+
+ case "4": {
dnssecStatus = '
ABANDONED';
break;
- case "5":
+ }
+
+ case "5": {
dnssecStatus = '
UNKNOWN';
break;
- default:
+ }
+
+ default: {
// No DNSSEC
dnssecStatus = "";
+ }
}
if (dnssecStatus.length > 0) {
@@ -121,13 +132,15 @@ $(function () {
}
switch (data[4]) {
- case "1":
+ case "1": {
fieldtext = "Blocked (gravity)";
buttontext =
'';
blocked = true;
break;
- case "2":
+ }
+
+ case "2": {
fieldtext =
replyid === 0
? "OK (sent to
"
@@ -137,42 +150,57 @@ $(function () {
buttontext =
'';
break;
- case "3":
+ }
+
+ case "3": {
fieldtext =
"OK
(cache)" + dnssecStatus;
buttontext =
'';
break;
- case "4":
- fieldtext = "Blocked
(regex blacklist)";
+ }
+
+ case "4": {
+ fieldtext =
+ "Blocked (regex blacklist)";
blocked = true;
buttontext =
'';
break;
- case "5":
+ }
+
+ case "5": {
fieldtext = "Blocked
(exact blacklist)";
blocked = true;
buttontext =
'';
break;
- case "6":
+ }
+
+ case "6": {
fieldtext = "Blocked
(external, IP)";
blocked = true;
buttontext = "";
break;
- case "7":
+ }
+
+ case "7": {
fieldtext =
"Blocked
(external, NULL)";
blocked = true;
buttontext = "";
break;
- case "8":
+ }
+
+ case "8": {
fieldtext =
"Blocked
(external, NXRA)";
blocked = true;
buttontext = "";
break;
- case "9":
+ }
+
+ case "9": {
fieldtext =
"Blocked
(gravity, CNAME)";
blocked = true;
@@ -180,7 +208,9 @@ $(function () {
'';
isCNAME = true;
break;
- case "10":
+ }
+
+ case "10": {
fieldtext =
"Blocked
(regex blacklist, CNAME)";
blocked = true;
@@ -188,7 +218,9 @@ $(function () {
'';
isCNAME = true;
break;
- case "11":
+ }
+
+ case "11": {
fieldtext =
"Blocked
(exact blacklist, CNAME)";
blocked = true;
@@ -196,38 +228,53 @@ $(function () {
'';
isCNAME = true;
break;
- case "12":
+ }
+
+ case "12": {
fieldtext = "Retried";
break;
- case "13":
+ }
+
+ case "13": {
fieldtext = "Retried
(ignored)";
break;
- case "14":
+ }
+
+ case "14": {
fieldtext =
"OK
(already forwarded)" +
dnssecStatus;
buttontext =
'';
break;
- case "15":
+ }
+
+ case "15": {
fieldtext =
"Blocked
(database is busy)";
blocked = true;
break;
- case "16":
+ }
+
+ case "16": {
fieldtext =
"Blocked
(special domain)";
blocked = true;
break;
- case "17":
+ }
+
+ case "17": {
fieldtext =
"OK
(stale cache)" +
dnssecStatus;
buttontext =
'';
break;
- default:
+ }
+
+ default: {
fieldtext = "Unknown (" + parseInt(data[4], 10) + ")";
+ }
}
// Add EDE here if available and not included in dnssecStatus
diff --git a/scripts/pi-hole/js/utils.js b/scripts/pi-hole/js/utils.js
index 16aa4473..97acff6e 100644
--- a/scripts/pi-hole/js/utils.js
+++ b/scripts/pi-hole/js/utils.js
@@ -77,7 +77,7 @@ function showAlert(type, icon, title, message) {
var opts = {};
title = " " + title + "
";
switch (type) {
- case "info":
+ case "info": {
opts = {
type: "info",
icon: "far fa-clock",
@@ -86,7 +86,9 @@ function showAlert(type, icon, title, message) {
};
info = $.notify(opts);
break;
- case "success":
+ }
+
+ case "success": {
opts = {
type: "success",
icon: icon,
@@ -100,7 +102,9 @@ function showAlert(type, icon, title, message) {
}
break;
- case "warning":
+ }
+
+ case "warning": {
opts = {
type: "warning",
icon: "fas fa-exclamation-triangle",
@@ -114,7 +118,9 @@ function showAlert(type, icon, title, message) {
}
break;
- case "error":
+ }
+
+ case "error": {
opts = {
type: "danger",
icon: "fas fa-times",
@@ -128,6 +134,8 @@ function showAlert(type, icon, title, message) {
}
break;
+ }
+
default:
}
}
@@ -200,12 +208,12 @@ function validateIPv6CIDR(ip) {
}
function validateMAC(mac) {
- var macvalidator = new RegExp(/^([\da-fA-F]{2}:){5}([\da-fA-F]{2})$/);
+ var macvalidator = /^([\da-fA-F]{2}:){5}([\da-fA-F]{2})$/;
return macvalidator.test(mac);
}
function validateHostname(name) {
- var namevalidator = new RegExp(/[^<>;"]/);
+ var namevalidator = /[^<>;"]/;
return namevalidator.test(name);
}