From 68ce56fc56175c69711f9495d02223faf2564c6d Mon Sep 17 00:00:00 2001 From: Adam Warner Date: Wed, 6 May 2020 23:19:50 +0100 Subject: [PATCH 1/3] show a clickable "." when there is a blank domain in the top domain lists Signed-off-by: Adam Warner --- scripts/pi-hole/js/index.js | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/scripts/pi-hole/js/index.js b/scripts/pi-hole/js/index.js index 5fffa248..177e7554 100644 --- a/scripts/pi-hole/js/index.js +++ b/scripts/pi-hole/js/index.js @@ -686,7 +686,8 @@ function updateTopLists() { } domain = escapeHtml(domain); - url = '' + domain + ""; + var urlText = domain == "" ? "." : domain; + url = '' + urlText + ""; percentage = (data.top_queries[domain] / data.dns_queries_today) * 100; domaintable.append( " " + @@ -720,7 +721,8 @@ function updateTopLists() { } domain = escapeHtml(domain); - url = '' + domain + ""; + var urlText = domain == "" ? "." : domain; + url = '' + urlText + ""; percentage = (data.top_ads[domain] / data.ads_blocked_today) * 100; adtable.append( " " + From b86ff763c021e1057b327733a79a36c8c94ce05d Mon Sep 17 00:00:00 2001 From: DL6ER Date: Thu, 7 May 2020 07:52:18 +0200 Subject: [PATCH 2/3] Address xo complaints. Signed-off-by: DL6ER --- scripts/pi-hole/js/index.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/scripts/pi-hole/js/index.js b/scripts/pi-hole/js/index.js index 177e7554..bb24db6f 100644 --- a/scripts/pi-hole/js/index.js +++ b/scripts/pi-hole/js/index.js @@ -676,7 +676,7 @@ function updateTopLists() { .remove(); var domaintable = $("#domain-frequency").find("tbody:last"); var adtable = $("#ad-frequency").find("tbody:last"); - var url, domain, percentage; + var url, domain, percentage, urlText; for (domain in data.top_queries) { if (Object.prototype.hasOwnProperty.call(data.top_queries, domain)) { // Sanitize domain @@ -686,7 +686,7 @@ function updateTopLists() { } domain = escapeHtml(domain); - var urlText = domain == "" ? "." : domain; + urlText = domain === "" ? "." : domain; url = '' + urlText + ""; percentage = (data.top_queries[domain] / data.dns_queries_today) * 100; domaintable.append( @@ -721,7 +721,7 @@ function updateTopLists() { } domain = escapeHtml(domain); - var urlText = domain == "" ? "." : domain; + urlText = domain === "" ? "." : domain; url = '' + urlText + ""; percentage = (data.top_ads[domain] / data.ads_blocked_today) * 100; adtable.append( From cc4e3c9a959d3e68d310a7b890387eb20394cd5a Mon Sep 17 00:00:00 2001 From: DL6ER Date: Thu, 7 May 2020 09:16:25 +0200 Subject: [PATCH 3/3] Query Log and long-term data Query Log: Substitute empty domains by "." Signed-off-by: DL6ER --- scripts/pi-hole/js/db_queries.js | 8 ++++++++ scripts/pi-hole/js/queries.js | 11 +++++++++-- 2 files changed, 17 insertions(+), 2 deletions(-) diff --git a/scripts/pi-hole/js/db_queries.js b/scripts/pi-hole/js/db_queries.js index f8c22119..0952674a 100644 --- a/scripts/pi-hole/js/db_queries.js +++ b/scripts/pi-hole/js/db_queries.js @@ -346,6 +346,14 @@ $(document).ready(function() { $(row).css("color", color); $("td:eq(4)", row).html(fieldtext); $("td:eq(5)", row).html(buttontext); + + // Substitute domain by "." if empty + var domain = data[2]; + if (domain.length === 0) { + domain = "."; + } + + $("td:eq(2)", row).text(domain); }, dom: "<'row'<'col-sm-12'f>>" + diff --git a/scripts/pi-hole/js/queries.js b/scripts/pi-hole/js/queries.js index 7ea1a6d7..dffcd85e 100644 --- a/scripts/pi-hole/js/queries.js +++ b/scripts/pi-hole/js/queries.js @@ -293,11 +293,18 @@ $(document).ready(function() { $("td:eq(4)", row).addClass("pointer"); } - // Add domain in CNAME chain causing the query to have been blocked + // Substitute domain by "." if empty var domain = data[2]; - var CNAME_domain = data[8]; + if (domain.length === 0) { + domain = "."; + } + if (isCNAME) { + var CNAME_domain = data[8]; + // Add domain in CNAME chain causing the query to have been blocked $("td:eq(2)", row).text(domain + "\n(blocked " + CNAME_domain + ")"); + } else { + $("td:eq(2)", row).text(domain); } // Check for existence of sixth column and display only if not Pi-holed