Dominik
0d2fcd09ef
Merge pull request #1872 from pi-hole/tweak/DBexport
...
Remove config option database.DBexport
2024-03-17 20:34:36 +01:00
DL6ER
75b792f589
Update embedded SQLite3 to 3.45.2
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2024-03-17 06:21:24 +01:00
Dominik
c835795a7b
Merge pull request #1884 from pi-hole/fix/overTimeGraphs
...
Tweak API history endpoint and fix cached counting
2024-03-16 19:57:08 +01:00
DL6ER
ccbe642dae
Add validator for webserver.api.client_history_global_max
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2024-03-16 10:12:11 +01:00
DL6ER
66653ae0d5
Merge branch 'development-v6' into fix/overTimeGraphs
2024-03-16 09:05:00 +01:00
DL6ER
e3f9aa712b
Work on a copy of the env vars to avoid modifying the original causing issues down the line when FTL restarts internally and re-reads them
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2024-03-16 08:52:58 +01:00
DL6ER
d408362efe
Remove (undocumented) advanced flag in details config output
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2024-03-16 08:36:37 +01:00
DL6ER
74eba5f605
Remove config option database.DBexport. Its implementation was broken by design as its value was always overwritten by the condition (database.maxDBdays > 0). Replace it with exactly this condition and document the behavior in the config file
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2024-03-16 08:34:19 +01:00
Dominik
4f6225cf3f
Merge pull request #1910 from pi-hole/tweak/config-validation
...
Allow upper case letters in domains/hosts
2024-03-16 06:46:47 +01:00
Adam Warner
8d4bf22008
Uncomment previously commented line which prevented the domain validator from accepting hostnames with capital letters in
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2024-03-16 00:16:59 +00:00
Adam Warner
4cd500dfac
demote warning log message about not being able to open /sys/class/hwmon to the API debug log to prevent it from filling up the log when not available
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2024-03-15 23:50:17 +00:00
DL6ER
2e23e76e0a
Add searching for domains and clients in the Query Log. Wildcards (*) are supported everywhere in the search string.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2024-03-14 19:45:45 +01:00
Dominik
2f38061f02
Merge pull request #1906 from pi-hole/tweak/goodbye_adam_mode
...
Goodbye Adam mode
2024-03-12 21:34:48 +01:00
DL6ER
ac21427e55
Add missing validator for database.useWAL
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2024-03-12 20:35:35 +01:00
Dominik
1bb74b3025
Merge pull request #1773 from pi-hole/new/validator
...
Add additional config validation
2024-03-12 20:29:06 +01:00
DL6ER
0eeeb8109c
Goodbye Adam mode
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2024-03-12 17:21:20 +01:00
DL6ER
aa7deb968e
Add CI tests for deep config validation
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2024-03-11 21:01:11 +01:00
Dominik
abcbcc58f5
Merge pull request #1901 from pi-hole/fix/revServerImporting
...
Fix revServer importing from former setupVars.conf
2024-03-11 19:14:08 +01:00
DL6ER
4f3bd87807
Only add active entries
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2024-03-08 08:18:05 +01:00
DL6ER
ef84283a69
Use correct variable when migrating possible revServer settings from setupVars.conf to the new multiple-servers-aware JSON string formulation
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2024-03-07 21:35:51 +01:00
DL6ER
231a9853bd
If dns.domainNeeded is set, refuse to send plain domain queries (like laptop) upstream at all.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2024-03-07 16:58:52 +01:00
DL6ER
ad46a1018a
We should only set local=/<domain>/ if there is no conditional forwarding setting (v6 supports multiple reverse lookup servers), otherwise, this creates a harmless but nonetheless needlessly confusing configuration.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2024-03-07 16:55:11 +01:00
bungh0l10
b53d969b83
Update config.c fix typo 5335 instead of 5353
...
Signed-off-by: bungh0l10 <77304055+bungh0l10@users.noreply.github.com >
2024-03-05 21:59:46 +01:00
Dominik
93d01d9c5d
Merge pull request #1891 from pi-hole/fix/migration_message
...
Improve config migration logging
2024-03-04 19:41:57 +01:00
Dominik
4b2a4be94c
Merge pull request #1868 from pi-hole/new/useWAL
...
Make WAL mode for pihole-FTL.db optional
2024-03-04 19:40:29 +01:00
Dominik
7ef8e6c916
Merge pull request #1882 from pi-hole/merge-v5-6
...
Sync v5 -> v6
2024-03-02 18:30:31 +01:00
Dominik
d4792bb70c
Merge pull request #1886 from pi-hole/tweak/allow_adlist_dups
...
Allow adlist duplicates
2024-03-02 18:28:41 +01:00
DL6ER
47f48781ac
Merge branch 'development-v6' into new/migrate_dnsmasq_conf
2024-02-19 21:28:02 +01:00
Simon Kelley
157b589391
Fix spurious "resource limit exceeded" messages.
...
Replies from upstream with a REFUSED rcode can result in
log messages stating that a resource limit has been exceeded,
which is not the case.
Thanks to Dominik Derigs and the Pi-hole project for
spotting this.
Signed-off-by: DL6ER <dl6er@dl6er.de >
2024-02-19 13:59:52 +01:00
DL6ER
485080a51d
Use correct index for domains in the Top Lists
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2024-02-18 21:06:43 +01:00
DL6ER
814362c256
Apply the same fix also to /stats/upstreams - this endpoint is actually not affected, however, it has a different logic that all the other endpoints now - fixing this eases maintanance and doesn't require us remembering that upstream destinations are never recycled (because there are only very few)
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2024-02-18 21:06:36 +01:00
DL6ER
d5cf5799c1
Merge branch 'development' into merge-v5-6
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2024-02-17 16:43:15 +01:00
DL6ER
d74d2a1e1c
Improve config migration logging
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2024-02-17 16:27:40 +01:00
DL6ER
e3c4dcf215
Restructure API response from /history/clients and /history/database/clients to allow for sparse data.
...
Add new config option webserver.api.client_history_global_max controling if the activities chart should sort and show the *global* (integrated over 24 hours) or the `local` (measured individually in each time slot) most active clients
Allow setting webserver.api.maxClients to 0 to always return all clients in /api/history/clients
Signed-off-by: DL6ER <dl6er@dl6er.de >
2024-02-16 17:15:20 +01:00
DL6ER
b986a82845
apply the same fix to other places in the API
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2024-02-15 19:52:38 +01:00
DL6ER
93e621cd54
Report only as many clients as we have added to the sorting array
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2024-02-14 14:42:20 +01:00
DL6ER
750db7ecda
Merge branch 'development-v6' into tweak/allow_adlist_dups
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2024-02-13 21:06:43 +01:00
Dominik
41725fd343
Merge pull request #1887 from pi-hole/tweak/apppw_descrition
...
Improve description of GET /auth/app endpoint
2024-02-13 21:05:42 +01:00
Dominik
2582043a2d
Apply code review
...
Co-authored-by: RD WebDesign <github@rdwebdesign.com.br >
Signed-off-by: Dominik <DL6ER@users.noreply.github.com >
2024-02-13 19:58:27 +01:00
DL6ER
96f4acb516
Add documentation for automatically added new DNSSEC-related metrics
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2024-02-13 17:03:05 +01:00
Simon Kelley
c95816f3b9
Reverse suppression of ANY query answer logging.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2024-02-13 16:46:14 +01:00
Simon Kelley
4b351cbe36
Add --dnssec-limits option.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2024-02-13 16:45:54 +01:00
Simon Kelley
cb577f318e
Better allocation code for DS digest cache.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2024-02-13 16:45:19 +01:00
Simon Kelley
dcd12a2be6
Better stats and logging from DNSSEC resource limiting.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2024-02-13 16:45:12 +01:00
Simon Kelley
84161ed295
Overhaul data checking in NSEC code.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2024-02-13 16:44:06 +01:00
Simon Kelley
1dbbdc96ca
Rework validate-by-DS to avoid DoS vuln without arbitrary limits.
...
By calculating the hash of a DNSKEY once for each digest algo,
we reduce the hashing work from (no. DS) x (no. DNSKEY) to
(no. DNSKEY) x (no. distinct digests)
The number of distinct digests can never be more than 255 and
it's limited by which hashes we implement, so currently only 4.
Signed-off-by: DL6ER <dl6er@dl6er.de >
2024-02-13 16:43:59 +01:00
Simon Kelley
b5e7dd448b
Update EDE code -> text conversion.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2024-02-13 16:43:11 +01:00
Simon Kelley
f141efdeba
Parameterise work limits for DNSSEC validation.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2024-02-13 16:43:03 +01:00
Simon Kelley
d92159a836
Fix error introduced in 635bc51cac3d5d7dd49ce9e27149cf7e402b7e79
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2024-02-13 16:40:32 +01:00
Simon Kelley
0b9e5543d2
Measure cryptographic work done by DNSSEC.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2024-02-13 16:40:27 +01:00