From e74c29fdd187a2dc8de257d70c09e30924ea70bf Mon Sep 17 00:00:00 2001 From: g0ldyy <153996346+g0ldyy@users.noreply.github.com> Date: Fri, 9 Jan 2026 22:44:47 +0100 Subject: [PATCH] fix: ETag caching broken by random manifest ID --- comet/api/endpoints/manifest.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/comet/api/endpoints/manifest.py b/comet/api/endpoints/manifest.py index 8d44588..5a0e3b6 100644 --- a/comet/api/endpoints/manifest.py +++ b/comet/api/endpoints/manifest.py @@ -58,7 +58,9 @@ async def manifest(request: Request, b64config: str = None): ) if settings.HTTP_CACHE_ENABLED: - etag = generate_etag(base_manifest) + base_manifest_etag_data = base_manifest.copy() + base_manifest_etag_data.pop("id", None) + etag = generate_etag(base_manifest_etag_data) if check_etag_match(request, etag): return not_modified_response(etag)