mobile: remove option "transfer images faster" (#1891)

apps/android/app/src/main/java/chat/simplex/app/model/SimpleXAPI.kt

@@ -88,7 +88,6 @@ class AppPreferences(val context: Context) {
   val webrtcIceServers = mkStrPreference(SHARED_PREFS_WEBRTC_ICE_SERVERS, null)
   val privacyProtectScreen = mkBoolPreference(SHARED_PREFS_PRIVACY_PROTECT_SCREEN, true)
   val privacyAcceptImages = mkBoolPreference(SHARED_PREFS_PRIVACY_ACCEPT_IMAGES, true)
-  val privacyTransferImagesInline = mkBoolPreference(SHARED_PREFS_PRIVACY_TRANSFER_IMAGES_INLINE, false)
   val privacyLinkPreviews = mkBoolPreference(SHARED_PREFS_PRIVACY_LINK_PREVIEWS, true)
   private val _simplexLinkMode = mkStrPreference(SHARED_PREFS_PRIVACY_SIMPLEX_LINK_MODE, SimplexLinkMode.default.name)
   val simplexLinkMode: SharedPreference<SimplexLinkMode> = SharedPreference(
@@ -935,7 +934,7 @@ open class ChatController(var ctrl: ChatCtrl?, val ntfManager: NtfManager, val a
     return false
   }
 
-  suspend fun apiReceiveFile(fileId: Long, inline: Boolean): AChatItem? {
+  suspend fun apiReceiveFile(fileId: Long, inline: Boolean? = null): AChatItem? {
     val r = sendCmd(CC.ReceiveFile(fileId, inline))
     return when (r) {
       is CR.RcvFileAccepted -> r.chatItem
@@ -1424,8 +1423,7 @@ open class ChatController(var ctrl: ChatCtrl?, val ntfManager: NtfManager, val a
   }
 
   suspend fun receiveFile(user: User, fileId: Long) {
-    val inline = appPrefs.privacyTransferImagesInline.get()
-    val chatItem = apiReceiveFile(fileId, inline)
+    val chatItem = apiReceiveFile(fileId)
     if (chatItem != null) {
       chatItemSimpleUpdate(user, chatItem)
     }
@@ -1798,7 +1796,7 @@ sealed class CC {
   class ApiRejectContact(val contactReqId: Long): CC()
   class ApiChatRead(val type: ChatType, val id: Long, val range: ItemRange): CC()
   class ApiChatUnread(val type: ChatType, val id: Long, val unreadChat: Boolean): CC()
-  class ReceiveFile(val fileId: Long, val inline: Boolean): CC()
+  class ReceiveFile(val fileId: Long, val inline: Boolean?): CC()
   class ShowVersion(): CC()
 
   val cmdString: String get() = when (this) {
@@ -1873,7 +1871,7 @@ sealed class CC {
     is ApiCallStatus -> "/_call status @${contact.apiId} ${callStatus.value}"
     is ApiChatRead -> "/_read chat ${chatRef(type, id)} from=${range.from} to=${range.to}"
     is ApiChatUnread -> "/_unread chat ${chatRef(type, id)} ${onOff(unreadChat)}"
-    is ReceiveFile -> "/freceive $fileId inline=${onOff(inline)}"
+    is ReceiveFile -> if (inline == null) "/freceive $fileId" else "/freceive $fileId inline=${onOff(inline)}"
     is ShowVersion -> "/version"
   }
 

apps/android/app/src/main/java/chat/simplex/app/views/usersettings/PrivacySettings.kt

@@ -51,8 +51,6 @@ fun PrivacySettingsView(
     SectionView(stringResource(R.string.settings_section_title_chats)) {
       SettingsPreferenceItem(Icons.Outlined.Image, stringResource(R.string.auto_accept_images), chatModel.controller.appPrefs.privacyAcceptImages)
       SectionDivider()
-      SettingsPreferenceItem(Icons.Outlined.ImageAspectRatio, stringResource(R.string.transfer_images_faster), chatModel.controller.appPrefs.privacyTransferImagesInline)
-      SectionDivider()
       SettingsPreferenceItem(Icons.Outlined.TravelExplore, stringResource(R.string.send_link_previews), chatModel.controller.appPrefs.privacyLinkPreviews)
       SectionDivider()
       SectionItemView { SimpleXLinkOptions(chatModel.simplexLinkMode, onSelected = {

apps/android/app/src/main/res/values-cs/strings.xml

@@ -467,7 +467,6 @@
     <string name="privacy_and_security">Ochrana osobních údajů a zabezpečení</string>
     <string name="your_privacy">Vaše soukromí</string>
     <string name="protect_app_screen">Ochrana obrazovky aplikace</string>
-    <string name="transfer_images_faster">Rychlejší přenos obrázků (BETA)</string>
     <string name="send_link_previews">Odesílání náhledů odkazů</string>
     <string name="full_backup">Zálohování dat aplikace</string>
     <string name="confirm_new_passphrase">Confirm new passphrase…</string>

apps/android/app/src/main/res/values-de/strings.xml

@@ -559,7 +559,6 @@
     <string name="your_privacy">Meine Privatsphäre</string>
     <string name="protect_app_screen">App-Bildschirm schützen</string>
     <string name="auto_accept_images">Bilder automatisch akzeptieren</string>
-    <string name="transfer_images_faster">Bilder schneller übertragen (BETA)</string>
     <string name="send_link_previews">Link-Vorschau senden</string>
     <string name="full_backup">App-Datensicherung</string>
     <!-- Settings sections -->

apps/android/app/src/main/res/values-fr/strings.xml

@@ -623,7 +623,6 @@
     <string name="privacy_and_security">Vie privée et sécurité</string>
     <string name="protect_app_screen">Protéger l\'écran de l\'app</string>
     <string name="auto_accept_images">Images auto-acceptées</string>
-    <string name="transfer_images_faster">Transfert d\'images plus rapide (BETA)</string>
     <string name="full_backup">Sauvegarde des données de l\'app</string>
     <string name="settings_section_title_you">VOUS</string>
     <string name="settings_section_title_help">AIDE</string>

apps/android/app/src/main/res/values-it/strings.xml

@@ -742,7 +742,6 @@
     <string name="settings_section_title_support">SUPPORTA SIMPLEX CHAT</string>
     <string name="settings_section_title_themes">TEMI</string>
     <string name="delete_chat_profile_action_cannot_be_undone_warning">Questa azione non può essere annullata: il tuo profilo, i contatti, i messaggi e i file andranno persi in modo irreversibile.</string>
-    <string name="transfer_images_faster">Trasferisci immagini più velocemente (BETA)</string>
     <string name="settings_section_title_you">TU</string>
     <string name="your_chat_database">Il tuo database della chat</string>
     <string name="your_current_chat_database_will_be_deleted_and_replaced_with_the_imported_one">Il tuo attuale database di chat verrà ELIMINATO e SOSTITUITO con quello importato.

apps/android/app/src/main/res/values-ru/strings.xml

@@ -560,7 +560,6 @@
     <string name="your_privacy">Конфиденциальность</string>
     <string name="protect_app_screen">Защитить экран приложения</string>
     <string name="auto_accept_images">Автоприем изображений</string>
-    <string name="transfer_images_faster">Передавать изображения в том же соединении (БЕТА)</string>
     <string name="send_link_previews">Отправлять картинки ссылок</string>
     <string name="full_backup">Резервная копия данных</string>
     <!-- Settings sections -->

apps/android/app/src/main/res/values/strings.xml

@@ -673,7 +673,6 @@
   <string name="your_privacy">Your privacy</string>
   <string name="protect_app_screen">Protect app screen</string>
   <string name="auto_accept_images">Auto-accept images</string>
-  <string name="transfer_images_faster">Transfer images inline (BETA)</string>
   <string name="send_link_previews">Send link previews</string>
   <string name="full_backup">App data backup</string>