From 09220be8e805dce8072a53aada815375de4fbbb7 Mon Sep 17 00:00:00 2001
From: Viren070 <viren070@protonmail.com>
Date: Sun, 4 May 2025 19:57:12 +0100
Subject: [PATCH] feat: improve error logs for stremthru/mediaflow

---
 packages/utils/src/mediaflow.ts | 6 +++++-
 packages/utils/src/stremthru.ts | 6 +++++-
 2 files changed, 10 insertions(+), 2 deletions(-)

diff --git a/packages/utils/src/mediaflow.ts b/packages/utils/src/mediaflow.ts
index 583f9730..7ca83ace 100644
--- a/packages/utils/src/mediaflow.ts
+++ b/packages/utils/src/mediaflow.ts
@@ -118,7 +118,7 @@ export async function getMediaFlowPublicIp(
     const mediaFlowUrl = new URL(mediaFlowConfig.proxyUrl.replace(/\/$/, ''));
     if (PRIVATE_CIDR.test(mediaFlowUrl.hostname)) {
       // MediaFlow proxy URL is a private IP address
-      logger.debug(
+      logger.error(
         'MediaFlow proxy URL is a private IP address so returning null'
       );
       return null;
@@ -162,6 +162,10 @@ export async function getMediaFlowPublicIp(
     const publicIp = data.ip;
     if (publicIp && cache) {
       cache.set(cacheKey, publicIp, Settings.CACHE_MEDIAFLOW_IP_TTL);
+    } else {
+      logger.error(
+        `MediaFlow did not respond with a public IP. Response: ${JSON.stringify(data)}`
+      );
     }
     return publicIp;
   } catch (error: any) {
diff --git a/packages/utils/src/stremthru.ts b/packages/utils/src/stremthru.ts
index 2fe0e6bd..9d7b16e7 100644
--- a/packages/utils/src/stremthru.ts
+++ b/packages/utils/src/stremthru.ts
@@ -118,7 +118,7 @@ export async function getStremThruPublicIp(
     const stremThruUrl = new URL(stremThruConfig.url.replace(/\/$/, ''));
     if (PRIVATE_CIDR.test(stremThruUrl.hostname)) {
       // StremThru URL is a private IP address
-      logger.debug('StremThru URL is a private IP address so returning null');
+      logger.error('StremThru URL is a private IP address so returning null');
       return null;
     }
 
@@ -157,6 +157,10 @@ export async function getStremThruPublicIp(
     const publicIp = data.data?.ip?.machine;
     if (publicIp && cache) {
       cache.set(cacheKey, publicIp, Settings.CACHE_STREMTHRU_IP_TTL);
+    } else {
+      logger.error(
+        `StremThru did not respond with a public IP address, please check a valid credential was used. Response: ${JSON.stringify(data)}`
+      );
     }
     return publicIp;
   } catch (error: any) {